netdev - Re: [PATCH net-next 2/3] virtio_net: fix possible dim status unrecoverable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 26 Apr 2024 10:55:39 +0800
From: Heng Qi <hengqi@...ux.alibaba.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, virtualization@...ts.linux.dev,
 "Michael S . Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
 Xuan Zhuo <xuanzhuo@...ux.alibaba.com>, Eric Dumazet <edumazet@...gle.com>,
 "David S . Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 2/3] virtio_net: fix possible dim status
 unrecoverable

在 2024/4/26 上午10:21, Jakub Kicinski 写道:
> On Thu, 25 Apr 2024 20:58:54 +0800 Heng Qi wrote:
>> When the dim worker is scheduled, if it no longer needs to issue
>> commands, dim may not be able to return to the working state later.
>>
>> For example, the following single queue scenario:
>>    1. The dim worker of rxq0 is scheduled, and the dim status is
>>       changed to DIM_APPLY_NEW_PROFILE;
>>    2. dim is disabled or parameters have not been modified;
>>    3. virtnet_rx_dim_work exits directly;
>>
>> Then, even if net_dim is invoked again, it cannot work because the
>> state is not restored to DIM_START_MEASURE.
>>
>> Fixes: 6208799553a8 ("virtio-net: support rx netdim")
>> Signed-off-by: Heng Qi <hengqi@...ux.alibaba.com>
> This sounds like a legitimate bug fix so it needs to be sent separately
> to the net tree (subject tagged with [PATCH net]) and then you'll have
> to wait until the following Thursday for the net tree to get merged
> into net-next. At which point you can send the improvements.
> (Without the wait there would be a conflict between the trees).

Yes, you are right, since this set is on top of the one DanJ is working on

(which I mentioned in the commit log and patchwork will warn about),

I merged the fix patch into this series. I'll wait for his set to be merged and push it again.

Thanks a lot!

>
> Right now the series does not apply to net-next anyway.