netdev - Re: [PATCH net-next] net: sfp-bus: constify link_modes to sfp_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 29 Apr 2024 08:25:11 +0000
From: Daniel Machon <daniel.machon@...rochip.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
CC: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] net: sfp-bus: constify link_modes to
 sfp_select_interface()

> sfp_select_interface() does not modify its link_modes argument, so
> make this a const pointer.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---
>  drivers/net/phy/sfp-bus.c | 2 +-
>  include/linux/sfp.h       | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/phy/sfp-bus.c b/drivers/net/phy/sfp-bus.c
> index c6e3baf00f23..37c85f1e6534 100644
> --- a/drivers/net/phy/sfp-bus.c
> +++ b/drivers/net/phy/sfp-bus.c
> @@ -355,7 +355,7 @@ EXPORT_SYMBOL_GPL(sfp_parse_support);
>   * modes mask.
>   */
>  phy_interface_t sfp_select_interface(struct sfp_bus *bus,
> -                                    unsigned long *link_modes)
> +                                    const unsigned long *link_modes)
>  {
>         if (phylink_test(link_modes, 25000baseCR_Full) ||
>             phylink_test(link_modes, 25000baseKR_Full) ||
> diff --git a/include/linux/sfp.h b/include/linux/sfp.h
> index 55c0ab17c9e2..5ebc57f78c95 100644
> --- a/include/linux/sfp.h
> +++ b/include/linux/sfp.h
> @@ -554,7 +554,7 @@ bool sfp_may_have_phy(struct sfp_bus *bus, const struct sfp_eeprom_id *id);
>  void sfp_parse_support(struct sfp_bus *bus, const struct sfp_eeprom_id *id,
>                        unsigned long *support, unsigned long *interfaces);
>  phy_interface_t sfp_select_interface(struct sfp_bus *bus,
> -                                    unsigned long *link_modes);
> +                                    const unsigned long *link_modes);
> 
>  int sfp_get_module_info(struct sfp_bus *bus, struct ethtool_modinfo *modinfo);
>  int sfp_get_module_eeprom(struct sfp_bus *bus, struct ethtool_eeprom *ee,
> @@ -593,7 +593,7 @@ static inline void sfp_parse_support(struct sfp_bus *bus,
>  }
> 
>  static inline phy_interface_t sfp_select_interface(struct sfp_bus *bus,
> -                                                  unsigned long *link_modes)
> +                                               const unsigned long *link_modes)

There seem to be some misalignment on the opening brace - at least in my
editor..

Other than that:

Reviewed-by: Daniel Machon <daniel.machon@...rochip.com>


>  {
>         return PHY_INTERFACE_MODE_NA;
>  }
> --
> 2.30.2
> 
>