netdev - Re: [PATCH v1 01/10] selftests/sgx: Compile with -D_GNU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 03 May 2024 04:46:43 +0300
From: "Jarkko Sakkinen" <jarkko@...nel.org>
To: "Edward Liaw" <edliaw@...gle.com>, <shuah@...nel.org>, "Mark Brown"
 <broonie@...nel.org>, "Jaroslav Kysela" <perex@...ex.cz>, "Takashi Iwai"
 <tiwai@...e.com>, "Jiri Kosina" <jikos@...nel.org>, "Benjamin Tissoires"
 <bentiss@...nel.org>, "Sean Christopherson" <seanjc@...gle.com>, "Paolo
 Bonzini" <pbonzini@...hat.com>, "Bongsu Jeon" <bongsu.jeon@...sung.com>,
 "David S. Miller" <davem@...emloft.net>, "Eric Dumazet"
 <edumazet@...gle.com>, "Jakub Kicinski" <kuba@...nel.org>, "Paolo Abeni"
 <pabeni@...hat.com>, "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
 "Dave Hansen" <dave.hansen@...ux.intel.com>, "Andrew Morton"
 <akpm@...ux-foundation.org>, "Muhammad Usama Anjum"
 <usama.anjum@...labora.com>
Cc: <linux-kernel@...r.kernel.org>, <linux-kselftest@...r.kernel.org>,
 <kernel-team@...roid.com>, <linux-sound@...r.kernel.org>,
 <linux-input@...r.kernel.org>, <kvm@...r.kernel.org>,
 <netdev@...r.kernel.org>, <linux-rtc@...r.kernel.org>,
 <linux-sgx@...r.kernel.org>, "kernel test robot" <oliver.sang@...el.com>
Subject: Re: [PATCH v1 01/10] selftests/sgx: Compile with -D_GNU_SOURCE

On Wed May 1, 2024 at 2:50 AM EEST, Edward Liaw wrote:
> 809216233555 ("selftests/harness: remove use of LINE_MAX") introduced
> asprintf into kselftest_harness.h, which is a GNU extension and needs
> _GNU_SOURCE to either be defined prior to including headers or with the
> -D_GNU_SOURCE flag passed to the compiler.
>
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Closes: https://lore.kernel.org/oe-lkp/202404301040.3bea5782-oliver.sang@intel.com
> Signed-off-by: Edward Liaw <edliaw@...gle.com>
> ---
>  tools/testing/selftests/sgx/Makefile    | 2 +-
>  tools/testing/selftests/sgx/sigstruct.c | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/sgx/Makefile b/tools/testing/selftests/sgx/Makefile
> index 867f88ce2570..272da790d9ae 100644
> --- a/tools/testing/selftests/sgx/Makefile
> +++ b/tools/testing/selftests/sgx/Makefile
> @@ -12,7 +12,7 @@ OBJCOPY := $(CROSS_COMPILE)objcopy
>  endif
>
>  INCLUDES := -I$(top_srcdir)/tools/include
> -HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC
> +HOST_CFLAGS := -Wall -Werror -g $(INCLUDES) -fPIC -D_GNU_SOURCE
>  HOST_LDFLAGS := -z noexecstack -lcrypto
>  ENCL_CFLAGS += -Wall -Werror -static-pie -nostdlib -ffreestanding -fPIE \
>  	       -fno-stack-protector -mrdrnd $(INCLUDES)
> diff --git a/tools/testing/selftests/sgx/sigstruct.c b/tools/testing/selftests/sgx/sigstruct.c
> index d73b29becf5b..a0c2de7c5302 100644
> --- a/tools/testing/selftests/sgx/sigstruct.c
> +++ b/tools/testing/selftests/sgx/sigstruct.c
> @@ -1,7 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
>  /*  Copyright(c) 2016-20 Intel Corporation. */
> -
> -#define _GNU_SOURCE
>  #include <assert.h>
>  #include <getopt.h>
>  #include <stdbool.h>
> --
> 2.45.0.rc0.197.gbae5840b3b-goog

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko