bugtraq - Re: Arbitrary code execution in eping plugin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20050611201509.27599.qmail@securityfocus.com>
Date: 11 Jun 2005 20:15:09 -0000
From: oliver@...ersquad.de
To: bugtraq@...urityfocus.com
Subject: Re: Arbitrary code execution in eping plugin

Hello,

the problem is in function eping_validaddr() in functions.php where the host is checked if it is valid as the name says...
But the only check is to see if it is a valid ip adress for eping, here is the code:

--------------8<-----------------------------------------8<-------------------------------------
function eping_validaddr($eping_hosttocheck)
{
If (ereg("(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)\.(25[0-5]|2[0-4][0-9]|[01]?[0-9][0-9]?)", $eping_hosttocheck))
   {
       return true;
   }
   else
   {
       return false;
   }
--------------8<-----------------------------------------8<-------------------------------------

I am sorry but I am a coder and my eyes are bleeding when looking at stuff like that so here is my suggestion for replaceing the if-statement:
if(preg_match("/^[0-9]{2,3}?\.[0-9]{1,3}?\.[0-9]{1,3}?\.[0-9]{1,3}?$/", $eping_hosttocheck))

So only IP-Adresses are allowed and no kind of code injection is possible.

And everyone who thinks 'will he ever stop writeing?' will be disappointed:
The same vulnerability also exists in the eTrace modul from E107. It looks like the same Author of the ePing modul.
The only difference is the you have to search for 'etrace' instead of 'eping' in the files

Greetings from Germany
Oliver

-- 

use the force - treat the source
http://codersquad.de