bugtraq - unzip TOCTOU file-permissions vulnerability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7389fc4b05080116031536adf7@mail.gmail.com>
Date: Tue, 2 Aug 2005 00:03:05 +0100
From: Imran Ghory <imranghory@...il.com>
To: bugtraq@...urityfocus.com
Subject: unzip TOCTOU file-permissions vulnerability

[Another compression utility with the same race condition issue as bzip2
 (CAN-2005-0953), gzip (CAN-2005-0988) and cpio (CAN-2005-1111) - the
file is extracted and file descriptor closed before the file is
chmod'ed]

================================
unzip TOCTOU file-permissions vulnerability
================================

Software: unzip
Version: 5.52
Software URL: <http://www.info-zip.org/pub/infozip/UnZip.html>
Platform:  Unix, Linux.
Vulnerability type: Time-of-Check-Time-Of-Use
Severity: Low, local user, badly set permissions.

Vulnerable software
====================

unzip 5.52 and previous versions running on unix.

Vulnerability
==============

If a malicious local user has write access to a directory in which a
target user is using unzip to extract a file to then a
TOCTOU bug can be exploited to change the permission of any file
belonging to that user.

On decompressing unzip copies the permissions from the compressed
 file to the uncompressed file. However there is a gap between the
uncompressed file being written (and it's file handler being close)
and the permissions of the file being changed.

During this gap a malicious user can remove the decompressed file and
replace it with a hard-link to another file belonging to the user.
unzip will then change the permissions on the  hard-linked file to be
the same as that of the compressed file.

The vulnerable line of code can be found on line 1160 of the file
unix.c where chmod is used (rather than fchmod). unzip also use's
chmod in a number of other places which may also be vulnerable to
exploitation.

Workaround
========

Ensure that any directory which is being used by unzip to
decompress files is only writeable by the user or
alternatively set the sticky bit on the directory's permissions.

---
Imran Ghory