bugtraq - Re: xine-lib NES Sound Format Demuxer Buffer Overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 24 Apr 2008 00:21:17 +0200
From: Guido Landi <lists@...mera.org>
To: laurent.gaffie@...il.com
Cc: bugtraq@...urityfocus.com
Subject: Re: xine-lib NES Sound Format Demuxer Buffer Overflow

that buffer can't be overflowed,  "header" is 128 byte long:

#define NSF_HEADER_SIZE 0x80
[..]
if (this->input->read(this->input, header, NSF_HEADER_SIZE) !=
  NSF_HEADER_SIZE)
  return 0;

and copyright can't be more than 50byte:

this->copyright = strdup(&header[0x4E]);



laurent.gaffie@...il.com wrote:
> Hi there
>
> Original advisory:
> http://milw0rm.com/exploits/5458
>
>
> There's another stack-based buffer overflow in demux_nfs.c
>
> line 111:
> this->copyright = strdup(&header[0x4E]);
> line 189:
> char copyright[100];
> line 208:
> sprintf(copyright, "(C) %s", this->copyright);
>
> Regards Laurent Gaffi�
>
>