full-disclosure - LOL, stupid calife maintainer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20040228180832.U43639@dekadens.coredump.cx>
From: lcamtuf at ghettot.org (Michal Zalewski)
Subject: LOL, stupid calife maintainer - this can't be
 true

On Sat, 28 Feb 2004, Timothy Demulder wrote:

>>         user_pass = (char *) xalloc (l_size);
>>             pt_pass = (char *) getpass ("Password:");
>>             strcpy (user_pass, pt_pass); // <- BAD CODE
>
> It's just plain sad, there should be capital punishement for people who
> code like this.

Uhh... sure... except that, quoting man getpass on Linux:

       The password may  be  up  to  128  characters  in  length,
       including  a  trailing NUL.  Any additional characters and
       the terminating newline character are discarded.

Unlike many other systems, however, Linux in fact DOES NOT obey this
limit, and returns more. Technically speaking, this is a specification
(standards compliance?) problem in Linux - although this guy most
definitely could be more careful.

-- 
------------------------- bash$ :(){ :|:&};: --
 Michal Zalewski * [http://lcamtuf.coredump.cx]
    Did you know that clones never use mirrors?
--------------------------- 2004-02-28 18:08 --

   http://lcamtuf.coredump.cx/photo/current/