full-disclosure - Re: Symlink vulnerabilities

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20111027173415.GA26291@devzero.fr>
Date: Thu, 27 Oct 2011 19:34:15 +0200
From: vladz <vladz@...zero.fr>
To: Benjamin Renaut <benml@...idev.fr>
Cc: full-disclosure@...ts.grok.org.uk
Subject: Re: Symlink vulnerabilities

On Thu, Oct 27, 2011 at 05:01:30PM +0200, Benjamin Renaut wrote:
> http://pastebin.com/FaaEsXRW

Nice thing, but for sure, it can be optimized. 

For example, to save time, I would suggest you to use rename() instead
of using both unlink() and rmdir() functions.  Same thing for your
write_shellcode() function, it contains too much calls.  It would be
preferable to create your nasty shell script first, and then (when it's
time), rename() it as dirname. 

Cheers,
-- 
http://vladz.devzero.fr
PGP key 8F7E2D3C from pgp.mit.edu

_______________________________________________
Full-Disclosure - We believe in it.
Charter: http://lists.grok.org.uk/full-disclosure-charter.html
Hosted and sponsored by Secunia - http://secunia.com/