full-disclosure - Re: [FD] Hilariously Bad SQRL Implementation

Open Source and information security mailing list archives

Message-ID: <CAPKwhwt61wrEZuNYnSihqX22R2xZTMgnjMhzZQvEUrbcK2-_FA@mail.gmail.com>
Date: Wed, 20 Aug 2014 17:33:01 -0400
From: Scott Arciszewski <kobrasrealm@...il.com>
To: Travis Biehn <tbiehn@...il.com>
Cc: fulldisclosure@...lists.org
Subject: Re: [FD] Hilariously Bad SQRL Implementation

Apparently, a barebones Android client exists.

https://twitter.com/SGgrc/status/501201214613123072

Unfortunately, I don't have access to the source code. Otherwise, I might
examine, thoroughly, what it's trying to do and write the spec for him.

On Wed, Aug 20, 2014 at 5:24 PM, Travis Biehn <tbiehn@...il.com> wrote:

> An additional note, the SQRL protocol itself is pretty poorly documented
> on the GRC website:
> https://www.grc.com/sqrl/details.htm
>
> Instead of writing technical specifications like online sales copy for
> penis pills perhaps we can get a draft in an ... RFC like format.
>
>
> On Sun, Aug 17, 2014 at 8:22 PM, Scott Arciszewski <kobrasrealm@...il.com>
> wrote:
>
>> If any of you are familiar with Stephen Gibson's SQRL protocol for user
>> authentication (really neat idea), you might have come across this PHP
>> implementation before: https://github.com/geir54/php-sqrl
>>
>> Unfortunately, this library is actually pretty terrible. Not only does it
>> pass all of the data off to a Heroku app to perform the signature
>> verification, it is also vulnerable to SQL Injection:
>>
>>
>> https://github.com/geir54/php-sqrl/blob/0fa574520a1843a33a84c3985f934e84af6f2042/sqrl_verify.php#L39-59
>>
>> I thought about submitting a pull request to fix this, but I don't believe
>> there is honestly much here to salvage. So, I'm writing my own
>> implementation here:
>>
>> https://github.com/darkitecht/php-sqrl <- Not ready, at all, for even
>> beta
>> testing.
>>
>> P.S. Also, it uses mt_rand() for challenge generation in a crypto library.
>> Tsk tsk.
>>
>> _______________________________________________
>> Sent through the Full Disclosure mailing list
>> http://nmap.org/mailman/listinfo/fulldisclosure
>> Web Archives & RSS: http://seclists.org/fulldisclosure/
>>
>
>
>
> --
> Twitter <https://twitter.com/tbiehn> | LinkedIn
> <http://www.linkedin.com/in/travisbiehn> | GitHub
> <http://github.com/tbiehn> | TravisBiehn.com <http://www.travisbiehn.com> |
> Google Plus <https://plus.google.com/+TravisBiehn>
>

_______________________________________________
Sent through the Full Disclosure mailing list
http://nmap.org/mailman/listinfo/fulldisclosure
Web Archives & RSS: http://seclists.org/fulldisclosure/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives