linux-cve-announce - CVE-2024-36977: usb: dwc3: Wait unconditionally after issuing EndXfer command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2024061804-CVE-2024-36977-e1e8@gregkh>
Date: Tue, 18 Jun 2024 21:28:05 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: CVE-2024-36977: usb: dwc3: Wait unconditionally after issuing EndXfer command

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

usb: dwc3: Wait unconditionally after issuing EndXfer command

Currently all controller IP/revisions except DWC3_usb3 >= 310a
wait 1ms unconditionally for ENDXFER completion when IOC is not
set. This is because DWC_usb3 controller revisions >= 3.10a
supports GUCTL2[14: Rst_actbitlater] bit which allows polling
CMDACT bit to know whether ENDXFER command is completed.

Consider a case where an IN request was queued, and parallelly
soft_disconnect was called (due to ffs_epfile_release). This
eventually calls stop_active_transfer with IOC cleared, hence
send_gadget_ep_cmd() skips waiting for CMDACT cleared during
EndXfer. For DWC3 controllers with revisions >= 310a, we don't
forcefully wait for 1ms either, and we proceed by unmapping the
requests. If ENDXFER didn't complete by this time, it leads to
SMMU faults since the controller would still be accessing those
requests.

Fix this by ensuring ENDXFER completion by adding 1ms delay in
__dwc3_stop_active_transfer() unconditionally.

The Linux kernel CVE team has assigned CVE-2024-36977 to this issue.

Affected and fixed versions
===========================

	Issue introduced in 6.1 with commit b353eb6dc285 and fixed in 6.1.92 with commit 341eb08dbca9
	Issue introduced in 6.1 with commit b353eb6dc285 and fixed in 6.6.32 with commit ec96bcf5f96a
	Issue introduced in 6.1 with commit b353eb6dc285 and fixed in 6.8.11 with commit 4a387e032909
	Issue introduced in 6.1 with commit b353eb6dc285 and fixed in 6.9.2 with commit 1ba145f05b5c
	Issue introduced in 6.1 with commit b353eb6dc285 and fixed in 6.10-rc1 with commit 1d26ba0944d3

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-36977
will be updated if fixes are backported, please check that for the most
up to date information about this issue.

Affected files
==============

The file(s) affected by this issue are:
	drivers/usb/dwc3/gadget.c

Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/341eb08dbca9eae05308c442fbfab1813a44c97a
	https://git.kernel.org/stable/c/ec96bcf5f96a7a5c556b0e881ac3e5c3924d542c
	https://git.kernel.org/stable/c/4a387e032909c6dc2b479452c5bbe9a252057925
	https://git.kernel.org/stable/c/1ba145f05b5c8f0b1a947a0633b5edff5dd1f1c5
	https://git.kernel.org/stable/c/1d26ba0944d398f88aaf997bda3544646cf21945