linux-cve-announce - CVE-2024-50142: xfrm: validate new SA's prefixlen using SA family when sel.family is unset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2024110743-CVE-2024-50142-e0dc@gregkh>
Date: Thu,  7 Nov 2024 10:34:42 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: CVE-2024-50142: xfrm: validate new SA's prefixlen using SA family when sel.family is unset

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

xfrm: validate new SA's prefixlen using SA family when sel.family is unset

This expands the validation introduced in commit 07bf7908950a ("xfrm:
Validate address prefix lengths in the xfrm selector.")

syzbot created an SA with
    usersa.sel.family = AF_UNSPEC
    usersa.sel.prefixlen_s = 128
    usersa.family = AF_INET

Because of the AF_UNSPEC selector, verify_newsa_info doesn't put
limits on prefixlen_{s,d}. But then copy_from_user_state sets
x->sel.family to usersa.family (AF_INET). Do the same conversion in
verify_newsa_info before validating prefixlen_{s,d}, since that's how
prefixlen is going to be used later on.

The Linux kernel CVE team has assigned CVE-2024-50142 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 2.6.12 with commit 1da177e4c3f4 and fixed in 5.15.170 with commit 2d08a6c31c65
	Issue introduced in 2.6.12 with commit 1da177e4c3f4 and fixed in 6.1.115 with commit bce1afaa212e
	Issue introduced in 2.6.12 with commit 1da177e4c3f4 and fixed in 6.6.59 with commit 7d9868180bd1
	Issue introduced in 2.6.12 with commit 1da177e4c3f4 and fixed in 6.11.6 with commit e68dd80ba498
	Issue introduced in 2.6.12 with commit 1da177e4c3f4 and fixed in 6.12-rc5 with commit 3f0ab59e6537

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-50142
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	net/xfrm/xfrm_user.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/2d08a6c31c65f23db71a5385ee9cf9d8f9a67a71
	https://git.kernel.org/stable/c/bce1afaa212ec380bf971614f70909a27882b862
	https://git.kernel.org/stable/c/7d9868180bd1e4cf37e7c5067362658971162366
	https://git.kernel.org/stable/c/e68dd80ba498265d2266b12dc3459164f4ff0c4a
	https://git.kernel.org/stable/c/3f0ab59e6537c6a8f9e1b355b48f9c05a76e8563