Message-ID: <2024111906-CVE-2024-53088-795c@gregkh>
Date: Tue, 19 Nov 2024 18:45:08 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: CVE-2024-53088: i40e: fix race condition by adding filter's intermediate sync state

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

i40e: fix race condition by adding filter's intermediate sync state

Fix a race condition in the i40e driver that leads to MAC/VLAN filters
becoming corrupted and leaking. Address the issue that occurs under
heavy load when multiple threads are concurrently modifying MAC/VLAN
filters by setting mac and port VLAN.

1. Thread T0 allocates a filter in i40e_add_filter() within
        i40e_ndo_set_vf_port_vlan().
2. Thread T1 concurrently frees the filter in __i40e_del_filter() within
        i40e_ndo_set_vf_mac().
3. Subsequently, i40e_service_task() calls i40e_sync_vsi_filters(), which
        refers to the already freed filter memory, causing corruption.

Reproduction steps:
1. Spawn multiple VFs.
2. Apply a concurrent heavy load by running parallel operations to change
        MAC addresses on the VFs and change port VLANs on the host.
3. Observe errors in dmesg:
"Error I40E_AQ_RC_ENOSPC adding RX filters on VF XX,
	please set promiscuous on manually for VF XX".

Exact code for stable reproduction Intel can't open-source now.

The fix involves implementing a new intermediate filter state,
I40E_FILTER_NEW_SYNC, for the time when a filter is on a tmp_add_list.
These filters cannot be deleted from the hash list directly but
must be removed using the full process.

The Linux kernel CVE team has assigned CVE-2024-53088 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 4.10 with commit 278e7d0b9d68 and fixed in 5.15.172 with commit 262dc6ea5f1e
	Issue introduced in 4.10 with commit 278e7d0b9d68 and fixed in 6.1.117 with commit 7ad3fb3bfd43
	Issue introduced in 4.10 with commit 278e7d0b9d68 and fixed in 6.6.61 with commit bf5f837d9fd2
	Issue introduced in 4.10 with commit 278e7d0b9d68 and fixed in 6.11.8 with commit 6e046f493747
	Issue introduced in 4.10 with commit 278e7d0b9d68 and fixed in 6.12 with commit f30490e9695e

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-53088
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/net/ethernet/intel/i40e/i40e.h
	drivers/net/ethernet/intel/i40e/i40e_debugfs.c
	drivers/net/ethernet/intel/i40e/i40e_main.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/262dc6ea5f1eb18c4d08ad83d51222d0dd0dd42a
	https://git.kernel.org/stable/c/7ad3fb3bfd43feb4e15c81dffd23ac4e55742791
	https://git.kernel.org/stable/c/bf5f837d9fd27d32fb76df0a108babcaf4446ff1
	https://git.kernel.org/stable/c/6e046f4937474bc1b9fa980c1ad8f3253fc638f6
	https://git.kernel.org/stable/c/f30490e9695ef7da3d0899c6a0293cc7cd373567

Powered by blists - more mailing lists