linux-cve-announce - CVE-2025-21645: platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025011945-CVE-2025-21645-e342@gregkh>
Date: Sun, 19 Jan 2025 11:17:54 +0100
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: CVE-2025-21645: platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

platform/x86/amd/pmc: Only disable IRQ1 wakeup where i8042 actually enabled it

Wakeup for IRQ1 should be disabled only in cases where i8042 had
actually enabled it, otherwise "wake_depth" for this IRQ will try to
drop below zero and there will be an unpleasant WARN() logged:

kernel: atkbd serio0: Disabling IRQ1 wakeup source to avoid platform firmware bug
kernel: ------------[ cut here ]------------
kernel: Unbalanced IRQ 1 wake disable
kernel: WARNING: CPU: 10 PID: 6431 at kernel/irq/manage.c:920 irq_set_irq_wake+0x147/0x1a0

The PMC driver uses DEFINE_SIMPLE_DEV_PM_OPS() to define its dev_pm_ops
which sets amd_pmc_suspend_handler() to the .suspend, .freeze, and
.poweroff handlers. i8042_pm_suspend(), however, is only set as
the .suspend handler.

Fix the issue by call PMC suspend handler only from the same set of
dev_pm_ops handlers as i8042_pm_suspend(), which currently means just
the .suspend handler.

To reproduce this issue try hibernating (S4) the machine after a fresh boot
without putting it into s2idle first.

[ij: edited the commit message.]

The Linux kernel CVE team has assigned CVE-2025-21645 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 6.2 with commit 8e60615e8932167057b363c11a7835da7f007106 and fixed in 6.6.72 with commit 5cc621085e2b7a9b1905a98f8e5a86bb4aea2016
	Issue introduced in 6.2 with commit 8e60615e8932167057b363c11a7835da7f007106 and fixed in 6.12.10 with commit b25778c87a6bce40c31e92364f08aa6240309e25
	Issue introduced in 6.2 with commit 8e60615e8932167057b363c11a7835da7f007106 and fixed in 6.13-rc7 with commit dd410d784402c5775f66faf8b624e85e41c38aaf
	Issue introduced in 5.15.95 with commit 3fc9dc0340e0b5df8059313537b55f82c1e84e94
	Issue introduced in 6.1.11 with commit 72e5a83b7c8401856cc3732150af24e43726717a

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-21645
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/platform/x86/amd/pmc/pmc.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/5cc621085e2b7a9b1905a98f8e5a86bb4aea2016
	https://git.kernel.org/stable/c/b25778c87a6bce40c31e92364f08aa6240309e25
	https://git.kernel.org/stable/c/dd410d784402c5775f66faf8b624e85e41c38aaf