linux-cve-announce - CVE-2024-57953: rtc: tps6594: Fix integer overflow on 32bit systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025022631-CVE-2024-57953-9830@gregkh>
Date: Wed, 26 Feb 2025 18:05:31 -0800
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: CVE-2024-57953: rtc: tps6594: Fix integer overflow on 32bit systems

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

rtc: tps6594: Fix integer overflow on 32bit systems

The problem is this multiply in tps6594_rtc_set_offset()

	tmp = offset * TICKS_PER_HOUR;

The "tmp" variable is an s64 but "offset" is a long in the
(-277774)-277774 range.  On 32bit systems a long can hold numbers up to
approximately two billion.  The number of TICKS_PER_HOUR is really large,
(32768 * 3600) or roughly a hundred million.  When you start multiplying
by a hundred million it doesn't take long to overflow the two billion
mark.

Probably the safest way to fix this is to change the type of
TICKS_PER_HOUR to long long because it's such a large number.

The Linux kernel CVE team has assigned CVE-2024-57953 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 6.8 with commit 9f67c1e63976d3403f0b250b03ffe959c890f9db and fixed in 6.12.13 with commit 5127f3cbfc78a7b301b86328247230bec47e0bb3
	Issue introduced in 6.8 with commit 9f67c1e63976d3403f0b250b03ffe959c890f9db and fixed in 6.13.2 with commit 53b0c7b15accb18d15d95c7fe68f61630ebfd1ca
	Issue introduced in 6.8 with commit 9f67c1e63976d3403f0b250b03ffe959c890f9db and fixed in 6.14-rc1 with commit 09c4a610153286cef54d4f0c85398f4e32fc227e

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2024-57953
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/rtc/rtc-tps6594.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/5127f3cbfc78a7b301b86328247230bec47e0bb3
	https://git.kernel.org/stable/c/53b0c7b15accb18d15d95c7fe68f61630ebfd1ca
	https://git.kernel.org/stable/c/09c4a610153286cef54d4f0c85398f4e32fc227e