linux-cve-announce - CVE-2023-53106: nfc: st-nci: Fix use after free bug in ndlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025050226-CVE-2023-53106-e1a5@gregkh>
Date: Fri,  2 May 2025 17:56:11 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2023-53106: nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

nfc: st-nci: Fix use after free bug in ndlc_remove due to race condition

This bug influences both st_nci_i2c_remove and st_nci_spi_remove.
Take st_nci_i2c_remove as an example.

In st_nci_i2c_probe, it called ndlc_probe and bound &ndlc->sm_work
with llt_ndlc_sm_work.

When it calls ndlc_recv or timeout handler, it will finally call
schedule_work to start the work.

When we call st_nci_i2c_remove to remove the driver, there
may be a sequence as follows:

Fix it by finishing the work before cleanup in ndlc_remove

CPU0                  CPU1

                    |llt_ndlc_sm_work
st_nci_i2c_remove   |
  ndlc_remove       |
     st_nci_remove  |
     nci_free_device|
     kfree(ndev)    |
//free ndlc->ndev   |
                    |llt_ndlc_rcv_queue
                    |nci_recv_frame
                    |//use ndlc->ndev

The Linux kernel CVE team has assigned CVE-2023-53106 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 4.14.311 with commit 2156490c4b7cacda9a18ec99929940b8376dc0e3
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 4.19.279 with commit 3405eb641dafcc8b28d174784b203c1622c121bf
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 5.4.238 with commit b0c202a8dc63008205a5d546559736507a9aae66
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 5.10.176 with commit 43aa468df246175207a7d5d7d6d31b231f15b49c
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 5.15.104 with commit 84dd9cc34014e3a3dcce0eb6d54b8a067e97676b
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 6.1.21 with commit 5e331022b448fbc5e76f24349cd0246844dcad25
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 6.2.8 with commit f589e5b56c562d99ea74e05b1c3f0eab78aa17a3
	Issue introduced in 3.17 with commit 35630df68d6030daf12dde12ed07bbe26324e6ac and fixed in 6.3 with commit 5000fe6c27827a61d8250a7e4a1d26c3298ef4f6

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2023-53106
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/nfc/st-nci/ndlc.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/2156490c4b7cacda9a18ec99929940b8376dc0e3
	https://git.kernel.org/stable/c/3405eb641dafcc8b28d174784b203c1622c121bf
	https://git.kernel.org/stable/c/b0c202a8dc63008205a5d546559736507a9aae66
	https://git.kernel.org/stable/c/43aa468df246175207a7d5d7d6d31b231f15b49c
	https://git.kernel.org/stable/c/84dd9cc34014e3a3dcce0eb6d54b8a067e97676b
	https://git.kernel.org/stable/c/5e331022b448fbc5e76f24349cd0246844dcad25
	https://git.kernel.org/stable/c/f589e5b56c562d99ea74e05b1c3f0eab78aa17a3
	https://git.kernel.org/stable/c/5000fe6c27827a61d8250a7e4a1d26c3298ef4f6