linux-cve-announce - CVE-2025-38300: crypto: sun8i-ce-cipher - fix error handling in sun8i_ce_cipher

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025071013-CVE-2025-38300-f040@gregkh>
Date: Thu, 10 Jul 2025 09:42:41 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2025-38300: crypto: sun8i-ce-cipher - fix error handling in sun8i_ce_cipher_prepare()

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

crypto: sun8i-ce-cipher - fix error handling in sun8i_ce_cipher_prepare()

Fix two DMA cleanup issues on the error path in sun8i_ce_cipher_prepare():

1] If dma_map_sg() fails for areq->dst, the device driver would try to free
   DMA memory it has not allocated in the first place. To fix this, on the
   "theend_sgs" error path, call dma unmap only if the corresponding dma
   map was successful.

2] If the dma_map_single() call for the IV fails, the device driver would
   try to free an invalid DMA memory address on the "theend_iv" path:
   ------------[ cut here ]------------
   DMA-API: sun8i-ce 1904000.crypto: device driver tries to free an invalid DMA memory address
   WARNING: CPU: 2 PID: 69 at kernel/dma/debug.c:968 check_unmap+0x123c/0x1b90
   Modules linked in: skcipher_example(O+)
   CPU: 2 UID: 0 PID: 69 Comm: 1904000.crypto- Tainted: G           O        6.15.0-rc3+ #24 PREEMPT
   Tainted: [O]=OOT_MODULE
   Hardware name: OrangePi Zero2 (DT)
   pc : check_unmap+0x123c/0x1b90
   lr : check_unmap+0x123c/0x1b90
   ...
   Call trace:
    check_unmap+0x123c/0x1b90 (P)
    debug_dma_unmap_page+0xac/0xc0
    dma_unmap_page_attrs+0x1f4/0x5fc
    sun8i_ce_cipher_do_one+0x1bd4/0x1f40
    crypto_pump_work+0x334/0x6e0
    kthread_worker_fn+0x21c/0x438
    kthread+0x374/0x664
    ret_from_fork+0x10/0x20
   ---[ end trace 0000000000000000 ]---

To fix this, check for !dma_mapping_error() before calling
dma_unmap_single() on the "theend_iv" path.

The Linux kernel CVE team has assigned CVE-2025-38300 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.5 with commit 06f751b613296cc34b86fc83fccaf30d646eb8bc and fixed in 6.1.142 with commit a0ac3f85b2e3ef529e852f252a70311f9029d5e6
	Issue introduced in 5.5 with commit 06f751b613296cc34b86fc83fccaf30d646eb8bc and fixed in 6.6.94 with commit c62b79c1c51303dbcb6edfa4de0ee176f4934c52
	Issue introduced in 5.5 with commit 06f751b613296cc34b86fc83fccaf30d646eb8bc and fixed in 6.12.34 with commit 19d267d9fad00d94ad8477899e38ed7c11f33fb6
	Issue introduced in 5.5 with commit 06f751b613296cc34b86fc83fccaf30d646eb8bc and fixed in 6.15.3 with commit 4051250e5db489f8ad65fc337e2677b9b568ac72
	Issue introduced in 5.5 with commit 06f751b613296cc34b86fc83fccaf30d646eb8bc and fixed in 6.16-rc1 with commit f31adc3e356f7350d4a4d68c98d3f60f2f6e26b3

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-38300
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/crypto/allwinner/sun8i-ce/sun8i-ce-cipher.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/a0ac3f85b2e3ef529e852f252a70311f9029d5e6
	https://git.kernel.org/stable/c/c62b79c1c51303dbcb6edfa4de0ee176f4934c52
	https://git.kernel.org/stable/c/19d267d9fad00d94ad8477899e38ed7c11f33fb6
	https://git.kernel.org/stable/c/4051250e5db489f8ad65fc337e2677b9b568ac72
	https://git.kernel.org/stable/c/f31adc3e356f7350d4a4d68c98d3f60f2f6e26b3