linux-cve-announce - CVE-2025-38348: wifi: p54: prevent buffer-overflow in p54_rx_eeprom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <2025071036-CVE-2025-38348-ffc7@gregkh>
Date: Thu, 10 Jul 2025 10:15:56 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2025-38348: wifi: p54: prevent buffer-overflow in p54_rx_eeprom_readback()

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

wifi: p54: prevent buffer-overflow in p54_rx_eeprom_readback()

Robert Morris reported:

|If a malicious USB device pretends to be an Intersil p54 wifi
|interface and generates an eeprom_readback message with a large
|eeprom->v1.len, p54_rx_eeprom_readback() will copy data from the
|message beyond the end of priv->eeprom.
|
|static void p54_rx_eeprom_readback(struct p54_common *priv,
|                                   struct sk_buff *skb)
|{
|        struct p54_hdr *hdr = (struct p54_hdr *) skb->data;
|        struct p54_eeprom_lm86 *eeprom = (struct p54_eeprom_lm86 *) hdr->data;
|
|        if (priv->fw_var >= 0x509) {
|                memcpy(priv->eeprom, eeprom->v2.data,
|                       le16_to_cpu(eeprom->v2.len));
|        } else {
|                memcpy(priv->eeprom, eeprom->v1.data,
|                       le16_to_cpu(eeprom->v1.len));
|        }
| [...]

The eeprom->v{1,2}.len is set by the driver in p54_download_eeprom().
The device is supposed to provide the same length back to the driver.
But yes, it's possible (like shown in the report) to alter the value
to something that causes a crash/panic due to overrun.

This patch addresses the issue by adding the size to the common device
context, so p54_rx_eeprom_readback no longer relies on possibly tampered
values... That said, it also checks if the "firmware" altered the value
and no longer copies them.

The one, small saving grace is: Before the driver tries to read the eeprom,
it needs to upload >a< firmware. the vendor firmware has a proprietary
license and as a reason, it is not present on most distributions by
default.

The Linux kernel CVE team has assigned CVE-2025-38348 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 5.4.295 with commit 12134f79e53eb56b0b0b7447fa0c512acf6a8422
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 5.10.239 with commit 9701f842031b825e2fd5f22d064166f8f13f6e4d
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 5.15.186 with commit 1f7f8168abe8cbe845ab8bb557228d44784a6b57
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 6.1.142 with commit f39b2f8c1549a539846e083790fad396ef6cd802
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 6.6.95 with commit 0e4dc150423b829c35cbcf399481ca11594fc036
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 6.12.35 with commit 6d05390d20f110de37d051a3e063ef0a542d01fb
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 6.15.4 with commit 714afb4c38edd19a057d519c1f9c5d164b43de94
	Issue introduced in 2.6.28 with commit 7cb770729ba895f73253dfcd46c3fcba45d896f9 and fixed in 6.16-rc1 with commit da1b9a55ff116cb040528ef664c70a4eec03ae99

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-38348
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/net/wireless/intersil/p54/fwio.c
	drivers/net/wireless/intersil/p54/p54.h
	drivers/net/wireless/intersil/p54/txrx.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/12134f79e53eb56b0b0b7447fa0c512acf6a8422
	https://git.kernel.org/stable/c/9701f842031b825e2fd5f22d064166f8f13f6e4d
	https://git.kernel.org/stable/c/1f7f8168abe8cbe845ab8bb557228d44784a6b57
	https://git.kernel.org/stable/c/f39b2f8c1549a539846e083790fad396ef6cd802
	https://git.kernel.org/stable/c/0e4dc150423b829c35cbcf399481ca11594fc036
	https://git.kernel.org/stable/c/6d05390d20f110de37d051a3e063ef0a542d01fb
	https://git.kernel.org/stable/c/714afb4c38edd19a057d519c1f9c5d164b43de94
	https://git.kernel.org/stable/c/da1b9a55ff116cb040528ef664c70a4eec03ae99