linux-cve-announce - CVE-2025-38569: benet: fix BUG when creating VFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025081909-CVE-2025-38569-7ad5@gregkh>
Date: Tue, 19 Aug 2025 19:18:16 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2025-38569: benet: fix BUG when creating VFs

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

benet: fix BUG when creating VFs

benet crashes as soon as SRIOV VFs are created:

 kernel BUG at mm/vmalloc.c:3457!
 Oops: invalid opcode: 0000 [#1] SMP KASAN NOPTI
 CPU: 4 UID: 0 PID: 7408 Comm: test.sh Kdump: loaded Not tainted 6.16.0+ #1 PREEMPT(voluntary)
 [...]
 RIP: 0010:vunmap+0x5f/0x70
 [...]
 Call Trace:
  <TASK>
  __iommu_dma_free+0xe8/0x1c0
  be_cmd_set_mac_list+0x3fe/0x640 [be2net]
  be_cmd_set_mac+0xaf/0x110 [be2net]
  be_vf_eth_addr_config+0x19f/0x330 [be2net]
  be_vf_setup+0x4f7/0x990 [be2net]
  be_pci_sriov_configure+0x3a1/0x470 [be2net]
  sriov_numvfs_store+0x20b/0x380
  kernfs_fop_write_iter+0x354/0x530
  vfs_write+0x9b9/0xf60
  ksys_write+0xf3/0x1d0
  do_syscall_64+0x8c/0x3d0

be_cmd_set_mac_list() calls dma_free_coherent() under a spin_lock_bh.
Fix it by freeing only after the lock has been released.

The Linux kernel CVE team has assigned CVE-2025-38569 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 6.1.131 with commit 4393452e6c0c027971ec9bcc9557f52e63db3f0a and fixed in 6.1.148 with commit 46d44a23a3723a89deeb65b13cddb17f8d9f2700
	Issue introduced in 6.6.83 with commit 41d731e7920387ea13e2fb440a1e235686faeeb9 and fixed in 6.6.102 with commit c377ba2be9430d165a98e4b782902ed630bc7546
	Issue introduced in 6.12.19 with commit fd1ef3b1bdd3fec683ebd19eb3acc6a2cb60b5c6 and fixed in 6.12.42 with commit 0ddfe8b127ef1149fddccb79db6e6eaba7738e7d
	Issue introduced in 6.14 with commit 1a82d19ca2d6835904ee71e2d40fd331098f94a0 and fixed in 6.15.10 with commit d5dc09ee5d74277bc47193fe28ce8703e229331b
	Issue introduced in 6.14 with commit 1a82d19ca2d6835904ee71e2d40fd331098f94a0 and fixed in 6.16.1 with commit f4e4e0c4bc4d799d6fa39055acdbc3af066cd13e
	Issue introduced in 6.14 with commit 1a82d19ca2d6835904ee71e2d40fd331098f94a0 and fixed in 6.17-rc1 with commit 5a40f8af2ba1b9bdf46e2db10e8c9710538fbc63
	Issue introduced in 5.4.291 with commit 797bb9439c0489bbea4b8808297ec7a569098667
	Issue introduced in 5.10.235 with commit 7cfae8627511361f90a1a22dfae556c3fbc5bd8d
	Issue introduced in 5.15.179 with commit 671aaa17bd3153e25526934f92307169ce927b5e
	Issue introduced in 6.13.7 with commit 227a829c9067bf03b1967e7e0b1a6777fd57edef

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2025-38569
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/net/ethernet/emulex/benet/be_cmds.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/46d44a23a3723a89deeb65b13cddb17f8d9f2700
	https://git.kernel.org/stable/c/c377ba2be9430d165a98e4b782902ed630bc7546
	https://git.kernel.org/stable/c/0ddfe8b127ef1149fddccb79db6e6eaba7738e7d
	https://git.kernel.org/stable/c/d5dc09ee5d74277bc47193fe28ce8703e229331b
	https://git.kernel.org/stable/c/f4e4e0c4bc4d799d6fa39055acdbc3af066cd13e
	https://git.kernel.org/stable/c/5a40f8af2ba1b9bdf46e2db10e8c9710538fbc63