Message-ID: <2025100119-CVE-2022-50459-2340@gregkh>
Date: Wed,  1 Oct 2025 13:45:29 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2022-50459: scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

scsi: iscsi: iscsi_tcp: Fix null-ptr-deref while calling getpeername()

Fix a NULL pointer crash that occurs when we are freeing the socket at the
same time we access it via sysfs.

The problem is that:

 1. iscsi_sw_tcp_conn_get_param() and iscsi_sw_tcp_host_get_param() take
    the frwd_lock and do sock_hold() then drop the frwd_lock. sock_hold()
    does a get on the "struct sock".

 2. iscsi_sw_tcp_release_conn() does sockfd_put() which does the last put
    on the "struct socket" and that does __sock_release() which sets the
    sock->ops to NULL.

 3. iscsi_sw_tcp_conn_get_param() and iscsi_sw_tcp_host_get_param() then
    call kernel_getpeername() which accesses the NULL sock->ops.

Above we do a get on the "struct sock", but we needed a get on the "struct
socket". Originally, we just held the frwd_lock the entire time but in
commit bcf3a2953d36 ("scsi: iscsi: iscsi_tcp: Avoid holding spinlock while
calling getpeername()") we switched to refcount based because the network
layer changed and started taking a mutex in that path, so we could no
longer hold the frwd_lock.

Instead of trying to maintain multiple refcounts, this just has us use a
mutex for accessing the socket in the interface code paths.

The Linux kernel CVE team has assigned CVE-2022-50459 to this issue.


Affected and fixed versions
===========================

	Issue introduced in 5.9 with commit bcf3a2953d36bbfb9bd44ccb3db0897d935cc485 and fixed in 5.10.150 with commit 884a788f065578bb640382279a83d1df433b13e6
	Issue introduced in 5.9 with commit bcf3a2953d36bbfb9bd44ccb3db0897d935cc485 and fixed in 5.15.75 with commit a26b0658751bb0a3b28386fca715333b104d32a2
	Issue introduced in 5.9 with commit bcf3a2953d36bbfb9bd44ccb3db0897d935cc485 and fixed in 5.19.17 with commit 897dbbc57d71e8a34ec1af8e573a142de457da38
	Issue introduced in 5.9 with commit bcf3a2953d36bbfb9bd44ccb3db0897d935cc485 and fixed in 6.0.3 with commit 0a0b861fce2657ba08ec356a74346b37ca4b2008
	Issue introduced in 5.9 with commit bcf3a2953d36bbfb9bd44ccb3db0897d935cc485 and fixed in 6.1 with commit 57569c37f0add1b6489e1a1563c71519daf732cf
	Issue introduced in 5.8.14 with commit 7d29e950766327f658cb92722b9445ac3b3ae023

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2022-50459
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/scsi/iscsi_tcp.c
	drivers/scsi/iscsi_tcp.h


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/884a788f065578bb640382279a83d1df433b13e6
	https://git.kernel.org/stable/c/a26b0658751bb0a3b28386fca715333b104d32a2
	https://git.kernel.org/stable/c/897dbbc57d71e8a34ec1af8e573a142de457da38
	https://git.kernel.org/stable/c/0a0b861fce2657ba08ec356a74346b37ca4b2008
	https://git.kernel.org/stable/c/57569c37f0add1b6489e1a1563c71519daf732cf

Powered by blists - more mailing lists