linux-cve-announce - CVE-2022-50486: net: ethernet: ti: Fix return type of netcp_ndo_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <2025100441-CVE-2022-50486-da3d@gregkh>
Date: Sat,  4 Oct 2025 17:16:45 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: linux-cve-announce@...r.kernel.org
Cc: Greg Kroah-Hartman <gregkh@...nel.org>
Subject: CVE-2022-50486: net: ethernet: ti: Fix return type of netcp_ndo_start_xmit()

From: Greg Kroah-Hartman <gregkh@...nel.org>

Description
===========

In the Linux kernel, the following vulnerability has been resolved:

net: ethernet: ti: Fix return type of netcp_ndo_start_xmit()

With clang's kernel control flow integrity (kCFI, CONFIG_CFI_CLANG),
indirect call targets are validated against the expected function
pointer prototype to make sure the call target is valid to help mitigate
ROP attacks. If they are not identical, there is a failure at run time,
which manifests as either a kernel panic or thread getting killed. A
proposed warning in clang aims to catch these at compile time, which
reveals:

  drivers/net/ethernet/ti/netcp_core.c:1944:21: error: incompatible function pointer types initializing 'netdev_tx_t (*)(struct sk_buff *, struct net_device *)' (aka 'enum netdev_tx (*)(struct sk_buff *, struct net_device *)') with an expression of type 'int (struct sk_buff *, struct net_device *)' [-Werror,-Wincompatible-function-pointer-types-strict]
          .ndo_start_xmit         = netcp_ndo_start_xmit,
                                    ^~~~~~~~~~~~~~~~~~~~
  1 error generated.

->ndo_start_xmit() in 'struct net_device_ops' expects a return type of
'netdev_tx_t', not 'int'. Adjust the return type of
netcp_ndo_start_xmit() to match the prototype's to resolve the warning
and CFI failure.

The Linux kernel CVE team has assigned CVE-2022-50486 to this issue.


Affected and fixed versions
===========================

	Fixed in 4.9.337 with commit a447479ea2cf35603b5739ea947885024b901222
	Fixed in 4.14.303 with commit 17bb9bdf701f3e811a9f4820b08b9538ade2641c
	Fixed in 4.19.270 with commit d837d74eae077cc3ef9e191ba8535b5f602d4673
	Fixed in 5.4.229 with commit dbe1a6b930ae9647e8ce0b684c903ac67d4398eb
	Fixed in 5.10.163 with commit 5b0b6553bf4ad3a435a57e02c68d6075f384e1be
	Fixed in 5.15.86 with commit a413ebb6049edd881c6427cfa25a7efddd6a4f74
	Fixed in 6.0.16 with commit 765636e58ba505cfe4927eda7ee83791b1c6402a
	Fixed in 6.1.2 with commit 1e4953b826e12b31995564a459dbd4e9e4604a35
	Fixed in 6.2 with commit 63fe6ff674a96cfcfc0fa8df1051a27aa31c70b4

Please see https://www.kernel.org for a full list of currently supported
kernel versions by the kernel community.

Unaffected versions might change over time as fixes are backported to
older supported kernel versions.  The official CVE entry at
	https://cve.org/CVERecord/?id=CVE-2022-50486
will be updated if fixes are backported, please check that for the most
up to date information about this issue.


Affected files
==============

The file(s) affected by this issue are:
	drivers/net/ethernet/ti/netcp_core.c


Mitigation
==========

The Linux kernel CVE team recommends that you update to the latest
stable kernel version for this, and many other bugfixes.  Individual
changes are never tested alone, but rather are part of a larger kernel
release.  Cherry-picking individual commits is not recommended or
supported by the Linux kernel community at all.  If however, updating to
the latest release is impossible, the individual changes to resolve this
issue can be found at these commits:
	https://git.kernel.org/stable/c/a447479ea2cf35603b5739ea947885024b901222
	https://git.kernel.org/stable/c/17bb9bdf701f3e811a9f4820b08b9538ade2641c
	https://git.kernel.org/stable/c/d837d74eae077cc3ef9e191ba8535b5f602d4673
	https://git.kernel.org/stable/c/dbe1a6b930ae9647e8ce0b684c903ac67d4398eb
	https://git.kernel.org/stable/c/5b0b6553bf4ad3a435a57e02c68d6075f384e1be
	https://git.kernel.org/stable/c/a413ebb6049edd881c6427cfa25a7efddd6a4f74
	https://git.kernel.org/stable/c/765636e58ba505cfe4927eda7ee83791b1c6402a
	https://git.kernel.org/stable/c/1e4953b826e12b31995564a459dbd4e9e4604a35
	https://git.kernel.org/stable/c/63fe6ff674a96cfcfc0fa8df1051a27aa31c70b4