linux-ext4 - Re: [patch 003/152] jbd: fix commit of ordered data buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060929212227.GA14030@elte.hu>
Date:	Fri, 29 Sep 2006 23:22:27 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...l.org>
Cc:	Andi Kleen <ak@...e.de>, Badari Pulavarty <pbadari@...ibm.com>,
	Jan Kara <jack@...e.cz>, torvalds@...l.org, stable@...nel.org,
	ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [patch 003/152] jbd: fix commit of ordered data buffers


* Andrew Morton <akpm@...l.org> wrote:

> +	if (cpu_isset(cpu, backtrace_mask)) {
> +		cpu_clear(cpu, backtrace_mask);
> +		printk("NMI backtrace for cpu %d\n", cpu);
> +		dump_stack();
> +	}

yeah. There's just one issue: this will mix all the printks from all 
CPUs at once (the NMIs if IO-APIC triggered fire at once). The way i 
solved this was to add a private spinlock around the printk and 
dump_stack().

	Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html