linux-ext4 - Re: Bug#389772: e2fsprogs: e2fsck produces broken htree on ppc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20060929171547.GO22010@schatzie.adilger.int>
Date:	Fri, 29 Sep 2006 11:15:47 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Theodore Tso <tytso@....edu>
Cc:	Jörg Sommer <joerg@...a.gnuu.de>,
	389772@...s.debian.org, paulus@...ibm.com,
	linux-ext4@...r.kernel.org
Subject: Re: Bug#389772: e2fsprogs: e2fsck produces broken htree on ppc

On Sep 28, 2006  21:08 -0400, Theodore Tso wrote:
> On Wed, Sep 27, 2006 at 02:22:51PM +0200, JÃ¶rg Sommer wrote:
> > Package: e2fsprogs
> > Version: 1.39-1
> > Severity: important
> > 
> > you set the compiler option -fsigned-char, but on PowerPC the default is
> > unsigned char. This makes the kernel uses unsigned and e2fsck uses signed
> > chars.
> > 
> > In the case of an 8 bit character, str2hashbuf() in lib/ext2fs/dirhash.c
> > produces a different buf than the kernel, which leads to the problem that
> > the hash calculated by TEA_transform() is a different one.
> 
> Oh, dear.  This is actually a kernel bug, because the on all other
> platforms, the TEA hash will be using a signed char --- and if you
> want filesystems to be portable between different systems (hint: we
> do), then all architectures should be using the same algorithm.  And
> the vast majority of the systems out there are using signed chars.
> Unfortunately PowerPC decided to be different.  :-(
> 
> But given that e2fsck is doing it right, and the kernel is doing it
> wrong, we have the mismatch already.  Sigh, this is going to be
> especially painful, given that all the major distributions (SLES,
> RHEL, Debian, Ubuntu, etc.) are now shipping with directory hashing
> enabled by default, and so this is going to impact a huge number of
> PowerPC Linux users and customers.

Hmm, except isn't the problem ALREADY that PPC is broken with 8-bit
chars and htree?  That's what started this problem in the first place.
Running e2fsck allowed the kernel htree code to find the file, when
it could not otherwise be looked up...  Need to verify that (my mental
stack is overflowing).

IIRC this problem was also reported in the past but no solution was found.
I think fixing the kernel to specify signed chars for the hash will FIX
the PPC kernel code.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html