linux-ext4 - Re: Updated ext4/jbd2 patches based on 2.6.19-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0610051619540.3952@g5.osdl.org>
Date:	Thu, 5 Oct 2006 16:25:39 -0700 (PDT)
From:	Linus Torvalds <torvalds@...l.org>
To:	Andrew Morton <akpm@...l.org>
cc:	Dave Kleikamp <shaggy@...tin.ibm.com>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: Updated ext4/jbd2 patches based on 2.6.19-rc1



On Thu, 5 Oct 2006, Andrew Morton wrote:
> 
> Linus, what's the best way of doing this?  Will git dtrt with a patch which
> copies files, or would a script which does the mkdir's and cp's be better?

Git should dtrt.

In fact, if you use

	git diff -C

it should generate the appropriate "file copied" things automatically, and 
you don't need any huge file at all, you'll get a "patch" that looks 
something like

	diff --git a/fs/ext3/inode.c b/fs/ext4/inode.c
	similarity index 100%
	copy from fs/ext3/inode.c
	copy to fs/ext4/inode.c
	diff --git a/fs/ext3/super.c b/fs/ext4/super.c
	similarity index 98%
	copy from fs/ext3/super.c
	copy to fs/ext4/super.c
	index xyz..zzy 100644
	--- a/fs/ext3/super.c
	+++ b/fs/ext4/super.c
	  .. small diff that changes "ext3" to "ext4" goes here ..


ie you'll effectively get the best of both worlds: a "diff", but one that 
is actually readable and shows what is going on.

I hate to beat my own drum (not really), but git really _is_ a lot better 
than anything else out there ;)

		Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html