linux-ext4 - [2.6 patch] ext4_ext_split(): remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20061106100554.GH5778@stusta.de>
Date:	Mon, 6 Nov 2006 11:05:54 +0100
From:	Adrian Bunk <bunk@...sta.de>
To:	ext2-devel@...ts.sourceforge.net
Cc:	linux-kernel@...r.kernel.org
Subject: [2.6 patch] ext4_ext_split(): remove dead code

The Coverity checker noted that this was dead code, since in all places 
above in this function, "err" is immediately checked.

Signed-off-by: Adrian Bunk <bunk@...sta.de>

--- linux-2.6/fs/ext4/extents.c.old	2006-11-06 11:02:09.000000000 +0100
+++ linux-2.6/fs/ext4/extents.c	2006-11-06 11:02:29.000000000 +0100
@@ -800,9 +800,6 @@ static int ext4_ext_split(handle_t *hand
 	}
 
 	/* insert new index */
-	if (err)
-		goto cleanup;
-
 	err = ext4_ext_insert_index(handle, inode, path + at,
 				    le32_to_cpu(border), newblock);
 

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html