linux-ext4 - + jbd-wait-for-already-submitted-t_sync_datalist-buffer.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200611292232.kATMWevr013719@shell0.pdx.osdl.net>
Date:	Wed, 29 Nov 2006 14:32:40 -0800
From:	akpm@...l.org
To:	mm-commits@...r.kernel.org
Cc:	hifumi.hisashi@....ntt.co.jp, jack@....cz,
	linux-ext4@...r.kernel.org, sct@...hat.com
Subject: + jbd-wait-for-already-submitted-t_sync_datalist-buffer.patch added to -mm tree


The patch titled
     jbd: wait for already submitted t_sync_datalist buffer to complete
has been added to the -mm tree.  Its filename is
     jbd-wait-for-already-submitted-t_sync_datalist-buffer.patch

See http://www.zip.com.au/~akpm/linux/patches/stuff/added-to-mm.txt to find
out what to do about this

------------------------------------------------------
Subject: jbd: wait for already submitted t_sync_datalist buffer to complete
From: Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>

In the current jbd code, if a buffer on BJ_SyncData list is dirty and not
locked, the buffer is refiled to BJ_Locked list, submitted to the IO and
waited for IO completion.

But the fsstress test showed the case that when a buffer was already
submitted to the IO just before the buffer_dirty(bh) check, the buffer was
not waited for IO completion.

Following patch solves this problem.  If it is assumed that a buffer is
submitted to the IO before the buffer_dirty(bh) check and still being
written to disk, this buffer is refiled to BJ_Locked list.

Signed-off-by: Hisashi Hifumi <hifumi.hisashi@....ntt.co.jp>
Cc: Jan Kara <jack@....cz>
Cc: "Stephen C. Tweedie" <sct@...hat.com>
Cc: <linux-ext4@...r.kernel.org>
Signed-off-by: Andrew Morton <akpm@...l.org>
---

 fs/jbd/commit.c |    8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diff -puN fs/jbd/commit.c~jbd-wait-for-already-submitted-t_sync_datalist-buffer fs/jbd/commit.c
--- a/fs/jbd/commit.c~jbd-wait-for-already-submitted-t_sync_datalist-buffer
+++ a/fs/jbd/commit.c
@@ -248,8 +248,12 @@ write_out_data:
 				bufs = 0;
 				goto write_out_data;
 			}
-		}
-		else {
+		} else if (!locked && buffer_locked(bh)) {
+			__journal_file_buffer(jh, commit_transaction,
+						BJ_Locked);
+			jbd_unlock_bh_state(bh);
+			put_bh(bh);
+		} else {
 			BUFFER_TRACE(bh, "writeout complete: unfile");
 			__journal_unfile_buffer(jh);
 			jbd_unlock_bh_state(bh);
_

Patches currently in -mm which might be from hifumi.hisashi@....ntt.co.jp are

jbd-wait-for-already-submitted-t_sync_datalist-buffer.patch

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html