linux-ext4 - Re: [PATCH 1/1] Extent overlap bugfix in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <459D4611.3090707@us.ibm.com>
Date:	Thu, 04 Jan 2007 10:23:13 -0800
From:	Mingming Cao <cmm@...ibm.com>
To:	Alex Tomas <alex@...sterfs.com>
CC:	"Amit K. Arora" <aarora@...ux.vnet.ibm.com>,
	linux-ext4@...r.kernel.org, suparna@...ibm.com
Subject: Re: [PATCH 1/1] Extent overlap bugfix in ext4

Alex Tomas wrote:
>>>>>>Mingming Cao (MC) writes:
> 
> 
>  MC> But the bug Amit pointed here is unrelated to the code convert
>  MC> uninitialized blocks to initialized ones. Rather, it's related to do
>  MC> multiple block allocation across on a window with parts already have
>  MC> blocks allocated. Without the check, the current code just simply
>  MC> allocate the requested extent and insert it into the tree which might
>  MC> overlap with existing extent.
> 
> correct. thanks for catching. in delayed allocation patch
> get_blocks() isn't used and ext4_ext_walk_space() works
> right in this case.
> 

Yep, I realized that yesterday. That explains we never see this overlap 
problem when we testing extent+delalloc+mballoc last year.

  ext4_ext_walk_space did almost all the overlap check.  I think we 
could reuse that code.

Mingming
> thanks, Alex
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html