linux-ext4 - Re: [PATCH 1/1 version2] Extent overlap bugfix in ext4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m3d55vf5r4.fsf@bzzz.home.net>
Date:	Thu, 04 Jan 2007 13:25:35 +0300
From:	Alex Tomas <alex@...sterfs.com>
To:	"Amit K. Arora" <aarora@...ux.vnet.ibm.com>
Cc:	Mingming Cao <cmm@...ibm.com>, linux-ext4@...r.kernel.org,
	suparna@...ibm.com, alex@...sterfs.com
Subject: Re: [PATCH 1/1 version2] Extent overlap bugfix in ext4

>>>>> Amit K Arora (AKA) writes:

 AKA> +int ext4_ext_check_overlap(struct inode *inode,
 AKA> +					struct ext4_extent *newext,
 AKA> +					unsigned long *block)
 AKA> +{
 AKA> +	struct ext4_ext_path *path;
 AKA> +	unsigned int depth, b1, len1;
 AKA> +	int ret = 0;
 AKA> +
 AKA> +	b1 = le32_to_cpu(newext->ee_block);
 AKA> +	len1 = le16_to_cpu(newext->ee_len);
 AKA> +	path = ext4_ext_find_extent(inode, b1, NULL);
 AKA> +	if (IS_ERR(path)) {
 AKA> +		ret = PTR_ERR(path);
 AKA> +		goto out;
 AKA> +	}
 AKA> +	depth = ext_depth(inode);
 AKA> +	BUG_ON(path[depth].p_ext == NULL && depth != 0);
 AKA> +
 AKA> +	*block = ext4_ext_next_allocated_block(path);
 AKA> +	if (*block == EXT_MAX_BLOCK)
 AKA> +		goto out;
 AKA> +
 AKA> +	if (b1 + len1 > *block)
 AKA> +		ret = 1;
 AKA> +out:
 AKA> +	return ret;

ext4_ext_find_extent() allocates 'path', I'd expect
kfree() in the function.

thanks, Alex
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html