linux-ext4 - Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070118104338.GZ5236@schatzie.adilger.int>
Date:	Thu, 18 Jan 2007 03:43:38 -0700
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Eric Sandeen <sandeen@...hat.com>
Cc:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] [RFC] remove ext3 inode from orphan list when link and unlink race

On Jan 17, 2007  16:47 -0600, Eric Sandeen wrote:
> Andreas Dilger wrote:
> > On Jan 12, 2007  14:45 -0600, Eric Sandeen wrote:
> >> p.s. ext3_inc_count and ext3_dec_count seem misnamed, have an unused
> >> arg, and are very infrequently called.  I'll probably submit a patch
> >> to just put the single line of code into the caller, too.
> > 
> > I use those functions in the > 32000 subdirs patch to handle the case
> > where a directory overflows the i_nlinks counter and needs to be set
> > to have i_nlinks = 1.
> > 
> > Patch was posted previously, but rejected because there is a potential
> > for directory loss if the filesystem is mounted on an older kernel
> > (i_nlinks == 1, subdir is removed, directory is truncated).  I need to
> > add an ROCOMPAT feature in order to handle this, but haven't gotten
> > around to doing it.
> 
> Ah, ok.  Sorry I'd missed that.  Can we at least rename them to
> something that makes sense? :)

I have no objection to renaming them, but had previously left them as-is
because it meant a smaller patch.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html