[<prev] [next>] [day] [month] [year] [list]
Message-Id: <200702100211.l1A2BGRU007105@igsi.llnl.gov>
Date: Fri, 9 Feb 2007 18:11:16 -0800
From: "Brian D. Behlendorf" <behlendorf1@...l.gov>
To: tytso@....edu
Cc: linux-ext4@...r.kernel.org, adilger@...sterfs.com,
behlendorf1@...l.gov, wartens2@...l.gov
Subject: e2fsprogs coverity patch <cid-19.diff>
Lawrence Livermore National Labs recently ran the source code
analysis tool Coverity over the e2fsprogs-1.39 source to see
if it would identify any significant bugs. The analysis
turned up 38 mostly minor issues which are enumerated here
with patches. We went through and resolved these issues
but would love to see these mostly minor changes reviewed
and commited upstream.
Thanks,
Brian Behlendorf <behlendorf1@...l.gov>, and
Herb Wartens <wartens2@...l.gov>
-----------------------------------------------------------------------------
Coverity ID: 19: Resource Leak
Need to close old_f before returning since it had been successfully opened
before.
Index: e2fsprogs+chaos/util/subst.c
===================================================================
--- e2fsprogs+chaos.orig/util/subst.c
+++ e2fsprogs+chaos/util/subst.c
@@ -273,8 +273,10 @@ static int compare_file(const char *outf
if (!old_f)
return 0;
new_f = fopen(newfn, "r");
- if (!new_f)
+ if (!new_f) {
+ fclose(old_f);
return 0;
+ }
while (1) {
oldcp = fgets(oldbuf, sizeof(oldbuf), old_f);
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists