| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <200702100211.l1A2BNXO007237@igsi.llnl.gov> Date: Fri, 9 Feb 2007 18:11:23 -0800 From: "Brian D. Behlendorf" <behlendorf1@...l.gov> To: tytso@....edu Cc: linux-ext4@...r.kernel.org, adilger@...sterfs.com, behlendorf1@...l.gov, wartens2@...l.gov Subject: e2fsprogs coverity patch <cid-26.diff> Lawrence Livermore National Labs recently ran the source code analysis tool Coverity over the e2fsprogs-1.39 source to see if it would identify any significant bugs. The analysis turned up 38 mostly minor issues which are enumerated here with patches. We went through and resolved these issues but would love to see these mostly minor changes reviewed and commited upstream. Thanks, Brian Behlendorf <behlendorf1@...l.gov>, and Herb Wartens <wartens2@...l.gov> ----------------------------------------------------------------------------- Coverity ID: 26+27: Resource Leak zero_buf and buf must be freed on return from this function. The other potential resource leaks in this function are handled by calling exit(). Index: e2fsprogs+chaos/misc/e2image.c =================================================================== --- e2fsprogs+chaos.orig/misc/e2image.c +++ e2fsprogs+chaos/misc/e2image.c @@ -442,6 +442,8 @@ static void output_meta_data_blocks(ext2 } } write_block(fd, zero_buf, sparse, 1, -1); + free(zero_buf); + free(buf); } static void write_raw_image_file(ext2_filsys fs, int fd, int scramble_flag) - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists