lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <200702100211.l1A2B8c0006999@igsi.llnl.gov> Date: Fri, 9 Feb 2007 18:11:08 -0800 From: "Brian D. Behlendorf" <behlendorf1@...l.gov> To: tytso@....edu Cc: linux-ext4@...r.kernel.org, adilger@...sterfs.com, behlendorf1@...l.gov, wartens2@...l.gov Subject: e2fsprogs coverity patch <cid-10.diff> Lawrence Livermore National Labs recently ran the source code analysis tool Coverity over the e2fsprogs-1.39 source to see if it would identify any significant bugs. The analysis turned up 38 mostly minor issues which are enumerated here with patches. We went through and resolved these issues but would love to see these mostly minor changes reviewed and commited upstream. Thanks, Brian Behlendorf <behlendorf1@...l.gov>, and Herb Wartens <wartens2@...l.gov> ----------------------------------------------------------------------------- Coverity ID: 10: Null Returns It is possible that e2fsck_get_dir_info() returns a NULL pointer. We do not want to blow up when dereferencing p. It seems to be more sane/safe to call fix_problem(ctx, PR_3_NO_DIRINFO, pctx) if p is NULL at this point since we do not have any DIRINFO for pctx->ino. Index: e2fsprogs+chaos/e2fsck/pass3.c =================================================================== --- e2fsprogs+chaos.orig/e2fsck/pass3.c +++ e2fsprogs+chaos/e2fsck/pass3.c @@ -306,6 +306,10 @@ static int check_directory(e2fsck_t ctx, ext2fs_unmark_valid(fs); else { p = e2fsck_get_dir_info(ctx, pctx->ino); + if(!p) { + fix_problem(ctx, PR_3_NO_DIRINFO, pctx); + return 0; + } p->parent = ctx->lost_and_found; fix_dotdot(ctx, p, ctx->lost_and_found); } - To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists