linux-ext4 - Re: e2fsprogs coverity patch <cid-11.diff>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070322005242.GA23643@thunk.org>
Date:	Wed, 21 Mar 2007 20:52:42 -0400
From:	Theodore Tso <tytso@....edu>
To:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
Cc:	"Brian D. Behlendorf" <behlendorf1@...l.gov>,
	linux-ext4@...r.kernel.org, adilger@...sterfs.com,
	wartens2@...l.gov
Subject: Re: e2fsprogs coverity patch <cid-11.diff>

On Wed, Mar 21, 2007 at 02:14:15PM -0500, Dave Kleikamp wrote:
> > > Coverity ID: 11: Overrun Static
> > > 
> > > -	thislen = ((dirent->name_len & 0xFF) < EXT2_NAME_LEN) ?
> > > +	thislen = ((dirent->name_len & 0xFF) <= EXT2_NAME_LEN) ?
> > >  		(dirent->name_len & 0xFF) : EXT2_NAME_LEN;
> > 
> > This change is largely meaningless/unnecessary, since if
> > *dirent->name_len & 0xFF) is equal to EXT2_NAME_LEN it doesn't matter
> > which path is chosen; was there a reason for the change.
> 
> #define EXT2_NAME_LEN 255
> 
> How about this?
> 
> 	thislen = dirent->name_len & 0xFF;

It's unlikely that EXT2_NAME_LEN will ever change, so yes, that's
probably a good idea.  I've alrady committed the patch, though so
we'll do it later.

						- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html