linux-ext4 - Re: [PATCH] Add i_version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070402232923.GU5967@schatzie.adilger.int>
Date:	Mon, 2 Apr 2007 17:29:23 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Mingming Cao <cmm@...ibm.com>
Cc:	Kalpak Shah <kalpak@...sterfs.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	TheodoreTso <tytso@....edu>,
	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>,
	Eric Sandeen <sandeen@...hat.com>
Subject: Re: [PATCH] Add i_version_hi for 64-bit version

On Apr 02, 2007  14:47 -0700, Mingming Cao wrote:
> On Sun, 2007-03-18 at 15:43 +0530, Kalpak Shah wrote:
> > This patch adds a 32-bit i_version_hi field to ext4_inode, which can be used for 64-bit inode versions. This field will store the higher 32 bits of the version, while Jean Noel's patch has added support to store the lower 32-bits in osd1.linux1.l_i_version.
> > 
> > Signed-off-by: Andreas Dilger <adilger@...sterfs.com>
> > Signed-off-by: Kalpak Shah <kalpak@...sterfs.com>
> > 
> > Index: linux-2.6.20/include/linux/ext4_fs.h
> > ===================================================================
> > --- linux-2.6.20.orig/include/linux/ext4_fs.h
> > +++ linux-2.6.20/include/linux/ext4_fs.h
> > @@ -336,6 +336,7 @@ struct ext4_inode {
> >         __le32  i_atime_extra;  /* extra Access time      (nsec << 2 | epoch) */
> >         __le32  i_crtime;       /* File Creation time */
> >         __le32  i_crtime_extra; /* extra File Creation time (nsec << 2 | epoch) */
> > +       __u32   i_version_hi;   /* high 32 bits for 64-bit version */
> >  };
> > 
> 
> Any reason not using __le32 for the i_version_hi?

Not really.  I've also asked Kalpak to run sparse with Shaggy's flags
against the other patches to fix up any similar issues.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html