linux-ext4 - [PATCH] libext2fs memory leak in ext2fs_write_new

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.61.0704041717470.1374@webb>
Date:	Wed, 4 Apr 2007 17:21:05 -0700 (PDT)
From:	Jim Garlick <garlick@...l.gov>
To:	tytso@....edu
cc:	linux-ext4@...r.kernel.org
Subject: [PATCH] libext2fs memory leak in ext2fs_write_new_inode()

The following patch addresses a memory leak in libext2fs
that occurs when using ext2fs_write_new_inode() on a file system
configured with large inodes.

Signed-off-by: Jim Garlick <garlick@...l.gov>

Index: e2fsprogs+chaos/lib/ext2fs/inode.c
===================================================================
--- e2fsprogs+chaos.orig/lib/ext2fs/inode.c
+++ e2fsprogs+chaos/lib/ext2fs/inode.c
@@ -752,6 +752,7 @@ errcode_t ext2fs_write_new_inode(ext2_fi
  	struct ext2_inode	*buf;
  	int 			size = EXT2_INODE_SIZE(fs->super);
  	struct ext2_inode_large	*large_inode;
+	errcode_t		rc;

  	if (size == sizeof(struct ext2_inode))
  		return ext2fs_write_inode_full(fs, ino, inode,
@@ -768,7 +769,9 @@ errcode_t ext2fs_write_new_inode(ext2_fi
  	large_inode->i_extra_isize = sizeof(struct ext2_inode_large) -
  		EXT2_GOOD_OLD_INODE_SIZE;

-	return ext2fs_write_inode_full(fs, ino, buf, size);
+	rc = ext2fs_write_inode_full(fs, ino, buf, size);
+	free(buf);
+	return rc;
  }

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html