lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <461BDAD5.5060900@redhat.com>
Date:	Tue, 10 Apr 2007 13:43:33 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	ext4 development <linux-ext4@...r.kernel.org>
Subject: [PATCH] e2fsprogs - handle large setb/testb/freeb commands in debugfs

I noticed that you can't give more than a 2^31 block count to the
debugfs commands setb, clearb, or freeb.  Looks ok?

Signed-off-by: Eric Sandeen <sandeen@...hat.com>

Index: e2fsprogs-1.39_ext4_hg/debugfs/debugfs.c
===================================================================
--- e2fsprogs-1.39_ext4_hg.orig/debugfs/debugfs.c
+++ e2fsprogs-1.39_ext4_hg/debugfs/debugfs.c
@@ -726,7 +726,7 @@ void do_testi(int argc, char *argv[])
 void do_freeb(int argc, char *argv[])
 {
 	blk_t block;
-	int count = 1;
+	blk_t count = 1;
 
 	if (common_block_args_process(argc, argv, &block, &count))
 		return;
@@ -745,7 +745,7 @@ void do_freeb(int argc, char *argv[])
 void do_setb(int argc, char *argv[])
 {
 	blk_t block;
-	int count = 1;
+	blk_t count = 1;
 
 	if (common_block_args_process(argc, argv, &block, &count))
 		return;
@@ -764,7 +764,7 @@ void do_setb(int argc, char *argv[])
 void do_testb(int argc, char *argv[])
 {
 	blk_t block;
-	int count = 1;
+	blk_t count = 1;
 
 	if (common_block_args_process(argc, argv, &block, &count))
 		return;
Index: e2fsprogs-1.39_ext4_hg/debugfs/util.c
===================================================================
--- e2fsprogs-1.39_ext4_hg.orig/debugfs/util.c
+++ e2fsprogs-1.39_ext4_hg/debugfs/util.c
@@ -325,7 +325,7 @@ int common_inode_args_process(int argc, 
  * This is a helper function used by do_freeb, do_setb, and do_testb
  */
 int common_block_args_process(int argc, char *argv[],
-			      blk_t *block, int *count)
+			      blk_t *block, blk_t *count)
 {
 	int	err;
 
Index: e2fsprogs-1.39_ext4_hg/debugfs/debugfs.h
===================================================================
--- e2fsprogs-1.39_ext4_hg.orig/debugfs/debugfs.h
+++ e2fsprogs-1.39_ext4_hg/debugfs/debugfs.h
@@ -41,7 +41,7 @@ extern int common_args_process(int argc,
 extern int common_inode_args_process(int argc, char *argv[],
 				     ext2_ino_t *inode, int flags);
 extern int common_block_args_process(int argc, char *argv[],
-				     blk_t *block, int *count);
+				     blk_t *block, blk_t *count);
 extern int debugfs_read_inode(ext2_ino_t ino, struct ext2_inode * inode,
 			      const char *cmd);
 extern int debugfs_read_inode_full(ext2_ino_t ino, struct ext2_inode * inode,


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ