linux-ext4 - Re: [PATCH] Accomodate 32-bit uid/guid values in e2fsprogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4640051E.4040703@redhat.com>
Date:	Tue, 08 May 2007 00:05:34 -0500
From:	Eric Sandeen <sandeen@...hat.com>
To:	Theodore Tso <tytso@....edu>
CC:	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [PATCH] Accomodate 32-bit uid/guid values in e2fsprogs

Theodore Tso wrote:
> On Mon, May 07, 2007 at 12:10:37PM -0500, Eric Sandeen wrote:
>> e2fsprogs doesn't handle large (> 16 bit) UID/GID...
> 
> Applied, with one correction:
> 
>> --- e2fsprogs-hg.orig/misc/mke2fs.c
>> +++ e2fsprogs-hg/misc/mke2fs.c
>> @@ -492,9 +494,14 @@ static void create_root_dir(ext2_filsys 
>>  				_("while reading root inode"));
>>  			exit(1);
>>  		}
>> -		inode.i_uid = getuid();
>> -		if (inode.i_uid)
>> -			inode.i_gid = getgid();
>> +		uid = getuid();
>> +		inode.i_uid = uid;
>> +		inode.i_uid_high = uid >> 16;
>> +		if (inode.i_uid) {
> 		    ^^^^^^^^^^^
> 
> This should be "uid" instead.  Otherwise, the gid won't be set if the
> uid is a multiple of 65536.
> 
> 						- Ted

Doh... dumb mistake.  nice catch.  thanks.

-Eric
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html