lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20070508174324.40EBE7B409F@zog.reactivated.net>
Date:	Tue,  8 May 2007 18:43:24 +0100 (BST)
From:	Daniel Drake <ddrake@...ntes3d.com>
To:	tytso@....edu
Cc:	linux-ext4@...r.kernel.org
Subject: [PATCH e2fsprogs] Restore backup superblocks in preen mode

The restoration of backup superblocks seems to be reversed in the current
e2fsprogs:

When running without preen mode, e2fsck searches and locates a backup
superblock and fixes the primary superblock without any user intervention.

When running in preen mode, e2fsck prints a message describing how the user
can specify the location of a backup superblock, and exits without doing any
repair.

This patch corrects the issue.

Signed-off-by: Daniel Drake <d.drake@....com>

Index: e2fsprogs-1.39/e2fsck/unix.c
===================================================================
--- e2fsprogs-1.39.orig/e2fsck/unix.c
+++ e2fsprogs-1.39/e2fsck/unix.c
@@ -932,7 +932,7 @@ restart:
 	} else 
 		retval = ext2fs_open2(ctx->filesystem_name, ctx->io_options, 
 				      flags, 0, 0, io_ptr, &fs);
-	if (!ctx->superblock && !(ctx->options & E2F_OPT_PREEN) &&
+	if (!ctx->superblock && (ctx->options & E2F_OPT_PREEN) &&
 	    !(ctx->flags & E2F_FLAG_SB_SPECIFIED) &&
 	    ((retval == EXT2_ET_BAD_MAGIC) ||
 	     ((retval == 0) && ext2fs_check_desc(fs)))) {
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ