linux-ext4 - Re: [PATCH] e2fsprogs: Check journal inode sanity and recreate journal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1180041743.3770.5.camel@garfield>
Date:	Fri, 25 May 2007 02:52:22 +0530
From:	Kalpak Shah <kalpak@...sterfs.com>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>,
	Eric Sandeen <sandeen@...hat.com>
Subject: Re: [PATCH] e2fsprogs: Check journal inode sanity and recreate
	journal

On Tue, 2007-05-08 at 01:40 -0400, Theodore Tso wrote:
> On Thu, Mar 15, 2007 at 02:43:47AM +0530, Kalpak Shah wrote:
> > Index: e2fsprogs-1.39/lib/ext2fs/mkjournal.c
> > ===================================================================
> > --- e2fsprogs-1.39.orig/lib/ext2fs/mkjournal.c
> > +++ e2fsprogs-1.39/lib/ext2fs/mkjournal.c
> > +	if (fs->super->s_blocks_count < 2048) {
> > +		fputs(("\nFilesystem too small for a journal\n"), stderr);
> > +		return 0;
> > +	}
> 
> Code in lib/ext2fs isn't allowed to do any output to stdio (except for
> debugging purposes).  It causes internationalization problems, and
> it's just in general a bad idea for ext2fs library code to try to do
> any UI.
> 
> 						- Ted

Hi Ted,

I have reworked the patch to make sure that lib/ext2fs does not do any
output. Added that to my mistakes-not-to-be-made-again list.

Signed-off-by: Kalpak Shah <kalpak@...sterfs.com>
Signed-off-by: Andreas Dilger <adilger@...sterfs.com>

Thanks,
Kalpak.

View attachment "recreate-journal.patch" of type "text/x-patch" (11652 bytes)