linux-ext4 - Re: ext2_discard_prealloc() called on each iput?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070529102544.GA25278@duck.suse.cz>
Date:	Tue, 29 May 2007 12:25:45 +0200
From:	Jan Kara <jack@...e.cz>
To:	Theodore Tso <tytso@....edu>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-ext4@...r.kernel.org
Subject: Re: ext2_discard_prealloc() called on each iput?

On Wed 23-05-07 08:37:43, Theodore Tso wrote:
> >   Also I found slightly misleading the comment at ext2_release_file().
> > As far as I understand the code it isn't when /all/ files are closed but
> > rather when all fd's for given filp are closed. I.e. if you open the same
> > file two times, ->release will get called once for each open. Am I right?
  <snip>
> still patches to fix the comments might not be a bad idea, since it
> might save confusion by others later on.
  OK, attached is a patch that fixes the comment. Andrew, please put it
into your patch queue... Thanks.

									Honza
-- 
Jan Kara <jack@...e.cz>
SuSE CR Labs

View attachment "ext2-2.6.21-1-comment_fix.diff" of type "text/x-patch" (882 bytes)