linux-ext4 - Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems larger than 32-bit blocks (take 2).

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1181049283.18452.0.camel@kleikamp.austin.ibm.com>
Date:	Tue, 05 Jun 2007 08:14:43 -0500
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	"Jose R. Santos" <jrs@...ibm.com>
Cc:	cmm@...ibm.com, Andreas Dilger <adilger@...sterfs.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>
Subject: Re: [RFC][PATCH] Set JBD2_FEATURE_INCOMPAT_64BIT on filesystems
	larger than 32-bit blocks (take 2).

On Tue, 2007-06-05 at 06:41 -0500, Jose R. Santos wrote:
> On Mon, 04 Jun 2007 16:01:45 -0700
> Mingming Cao <cmm@...ibm.com> wrote:
> 
> > On Mon, 2007-06-04 at 11:57 -0600, Andreas Dilger wrote:
> > > On Jun 04, 2007  11:32 -0500, Jose R. Santos wrote:
> > > > Set the journals JBD2_FEATURE_INCOMPAT_64BIT on devices with more
> > > > than 32bit block sizes during mount time.  This ensure proper record
> > > > lenth when writing to the journal.
> > > > 
> > > > Signed-off-by: Jose R. Santos <jrs@...ibm.com>
> > > > ---
> > > >  fs/ext4/super.c |   11 +++++++++++
> > > >  1 file changed, 11 insertions(+)
> > > > 
> > > > Index: linux-2.6.22-rc3/fs/ext4/super.c
> > > > ===================================================================
> > > > --- linux-2.6.22-rc3.orig/fs/ext4/super.c	2007-06-04 11:01:20.028360650 -0500
> > > > +++ linux-2.6.22-rc3/fs/ext4/super.c	2007-06-04 11:05:11.389126418 -0500
> > > > @@ -1824,6 +1824,17 @@ static int ext4_fill_super (struct super
> > > >  		goto failed_mount3;
> > > >  	}
> > > >  
> > > > +        /*
> > > > +	 * Make sure to set JBD2_FEATURE_INCOMPAT_64BIT on filesystems
> > > > +	 * with more that 32-bit block counts
> > > > +	 */
> > > > +	if(es->s_blocks_count_hi &&
> > 
> > This need to be le32_to_cpu(es->s_blocks_count_hi)
> 
> I'm curious,
> 
> Why do we need to do an endian conversion to check for a non-zero value
> in s_blocks_count_hi?  Seems unnecessary here.

Jose is right.  The endian conversion is unnecessary.

Shaggy
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html