lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Fri, 8 Jun 2007 16:47:26 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	linux-ext4@...r.kernel.org
Subject: ext4-delalloc-extents-48bit.patch

I just noticed while looking through ext4-delalloc-extents-48bit.patch in
git that it is doing all of the bit shifting explicitly, instead of using
the ext_pblock() and ext_store_pblock() helpers...

It also appears that some of the extent code is using "ee_len" directly
instead of the ext4_get_actual_len() helper to mask off the unwritten
extent flag (e.g. delalloc_extents*.patch).  I wonder if we should change
the ee_len type so that it isn't easy to access it directly (e.g. put it
inside a named union) so this mistake is visible more easily in the future.

Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists