[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20070611232306.GG5181@schatzie.adilger.int>
Date: Mon, 11 Jun 2007 17:23:06 -0600
From: Andreas Dilger <adilger@...sterfs.com>
To: Valerie Clement <valerie.clement@...l.net>
Cc: Theodore Tso <tytso@....edu>,
ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [RFC][PATCH 2/12] add new macro EXT2_DESC_PER_BLOCK in e2fsprogs
On Jun 11, 2007 18:42 +0200, Valerie Clement wrote:
> +#define EXT2_DESC_PER_BLOCK(s) (EXT2_BLOCK_SIZE(s) / \
> + ((EXT2_SB(s)->s_feature_incompat & EXT4_FEATURE_INCOMPAT_64BIT) ? \
> + sizeof(struct ext4_group_desc) : sizeof(struct ext2_group_desc)))
This should actually use s_desc_size and not "sizeof(struct ext4_group_desc)",
as we may want to increase the size of s_desc_size for some other reason in
the future.
Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists