[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <466E82B1.5000709@bull.net>
Date: Tue, 12 Jun 2007 13:25:37 +0200
From: Valerie Clement <valerie.clement@...l.net>
To: Andreas Dilger <adilger@...sterfs.com>
Cc: Theodore Tso <tytso@....edu>,
ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [RFC][PATCH 0/12] e2fsprogs: add 64-bit support
Andreas Dilger wrote:
> On Jun 11, 2007 18:41 +0200, Valerie Clement wrote:
>> This patchset is also not complete:
>> TODO:
>> - update code under ext2ed/,
>
> This code should just be removed entirely. It is dangerous to use, and
> by including it in e2fsprogs it lends a false sense of credibility to
> the code. Hopefully most of the functionality here has been incorporated
> into debugfs?
>
OK.
>> Code compiled, booted and briefly tested on a 20TB device (mkfs,
>> debugfs, e2fsck, dumpe2fs, filefrag tested)
>> Some non-regression tests also done on ext3 filesystems when compiling
>> code without _EXT4FS_ option.
>
> Did you run the "make check" tests? We've found these invaluable for
> catching regressions. Ideally there would also be some test cases
> for this support using "lazy_bg", a script to generate the filesystem,
> and conditional upon being able to create sparse files that big.
>
I missed to mention that some changes have to be done under tests/ too.
Without changes, "make check" fails.
Valérie
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists