linux-ext4 - Re: [RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20070612100537.GN5181@schatzie.adilger.int>
Date:	Tue, 12 Jun 2007 04:05:37 -0600
From:	Andreas Dilger <adilger@...sterfs.com>
To:	Valerie Clement <valerie.clement@...l.net>
Cc:	Theodore Tso <tytso@....edu>,
	ext4 development <linux-ext4@...r.kernel.org>
Subject: Re: [RFC][PATCH 7/12] handling of 64-bit block numbers in group desc in e2fsprogs

On Jun 11, 2007  18:45 +0200, Valerie Clement wrote:
> +#define EXT2_BLOCK_BITMAP(bg)		\
> +	((bg)->bg_block_bitmap + ((__u64)(bg)->bg_block_bitmap_hi << 32))
> +#define EXT2_INODE_BITMAP(bg)		\
> +	((bg)->bg_inode_bitmap + ((__u64)(bg)->bg_inode_bitmap_hi << 32))
> +#define EXT2_INODE_TABLE(bg)		\
> +	((bg)->bg_inode_table  + ((__u64)(bg)->bg_inode_table_hi  << 32))
> +
> +
> +#define EXT2_BLOCK_BITMAP(bg)		(bg)->bg_block_bitmap
> +#define EXT2_INODE_BITMAP(bg)		(bg)->bg_inode_bitmap
> +#define EXT2_INODE_TABLE(bg)		(bg)->bg_inode_table

This patch could go straight into e2fsprogs without compatibility problems
if they were properly conditional upon INCOMPAT_64BIT and s_desc_size.

> @@ -95,6 +95,11 @@ void ext2fs_swap_group_desc(struct ext2_
>  	gdp->bg_flags = ext2fs_swab16(gdp->bg_flags);
>  	gdp->bg_itable_unused = ext2fs_swab16(gdp->bg_itable_unused);
>  	gdp->bg_checksum = ext2fs_swab16(gdp->bg_checksum);
> +#ifdef _EXT4FS_
> +	gdp->bg_block_bitmap_hi = ext2fs_swab32(gdp->bg_block_bitmap_hi);
> +	gdp->bg_inode_bitmap_hi = ext2fs_swab32(gdp->bg_inode_bitmap_hi);
> +	gdp->bg_inode_table_hi = ext2fs_swab32(gdp->bg_inode_table_hi);
> +#endif

Same comment.


Cheers, Andreas
--
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html