linux-ext4 - Re: Patch to support LUKS UUIDs in libblkid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20070612234004.GA12189@thunk.org>
Date:	Tue, 12 Jun 2007 19:40:05 -0400
From:	Theodore Tso <tytso@....edu>
To:	Karsten Hopp <karsten@...hat.com>
Cc:	linux-ext4@...r.kernel.org
Subject: Re: Patch to support LUKS UUIDs in libblkid

On Mon, Jun 11, 2007 at 01:51:24PM +0200, Karsten Hopp wrote:
> +static int probe_luks(struct blkid_probe *probe,
> +		       struct blkid_magic *id __BLKID_ATTR((unused)), 
> +		       unsigned char *buf)
> +{
> +	unsigned char *p_buf = buf;
> +	unsigned char uuid[40];
> +	/* 168 is the offset to the 40 character uuid: 
> +	 * http://luks.endorphin.org/LUKS-on-disk-format.pdf */
> +	p_buf += 168;
> +	strncpy(uuid, p_buf, 40);

Why bother with p_buf?  It would actually be shorter and sweeter to
do:

	strncpy(uuid, buf+168, 40);

And remove the lines dealing with p_buf above.

> +  { "crypt_LUKS",0,	 0,  6,	"LUKS\xba\xbe",		probe_luks },

Any particular reason to use "crypt_LUKS" instead of just "LUKS"?  In
your documentation you generally just refer to it as LUKS.

					- Ted
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html