linux-ext4 - Re: [PATCH 0/6] inode version updated patches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4672A221.2050002@bull.net>
Date:	Fri, 15 Jun 2007 16:28:49 +0200
From:	Jean noel Cordenner <jean-noel.cordenner@...l.net>
To:	cmm@...ibm.com
Cc:	Kalpak Shah <kalpak@...sterfs.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>
Subject: Re: [PATCH 0/6] inode version updated patches

Mingming Cao a écrit :
> On Thu, 2007-06-14 at 21:26 +0530, Kalpak Shah wrote:
>> Hi,
>>
>> I have updated the inode version patches and below are the details:
>>
>> 64-bit-i_version.patch which only replaces the 32-bit i_version field in
>> the generic inode with a 64-bit i_version field. The VFS-level updates
>> of the inode version are still in the i_version_update_vfs.patch and
>> this patch has been moved to the bottom of the patch series.
>>
>> ext4_i_version_hi_2.patch was still using ei->i_fs_version instead of
>> inode->i_version. I have corrected this patch.
>>
>> Also there were whitespace problems in i_version_hi.patch.
>>
>> I am also attaching a ext4_no_version.patch which adds a "noversion"
>> mount option to disable inode version updates.
>>
>> I am not sure why i_version needs to be updated in VFS since it is being
>> updated in ext4_mark_iloc_dirty().
>>
> 
> Yes I think we can remove the inode version update in VFS patch. So I am
> going to drop the patch 5/6.  Jean Noel, if you disagree, please let me
> know.
> 

I agree, the update of the i_version in the vfs are done in
simple_rename() , simple_link() , simple_unlink() , which are mainly 
used by fs/ramfs and fs/hugetlbfs. So I think if each fs can update the 
i_version, that will be good.

Jean noel
-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html