linux-ext4 - Re: [PATCH] Endianness bugs in e2fsck

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1182368214.3969.7.camel@garfield>
Date:	Thu, 21 Jun 2007 01:06:48 +0530
From:	Kalpak Shah <kalpak@...sterfs.com>
To:	Theodore Tso <tytso@....edu>
Cc:	linux-ext4 <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>
Subject: Re: [PATCH] Endianness bugs in e2fsck

On Wed, 2007-06-20 at 11:09 -0400, Theodore Tso wrote:
> Hi Kalpak, 
> 
> 	In the future it would be really helpful if you split up your
> patches so that each different thing is done in separate patches.

Sure. Do you want me to split this patch too and resend?

> 
> 	Also, note there is a recent bug fix in this area, and the
> byte-swapping extended attributes.  The issues involved here are
> subtle; please see the discussion here:
> 
> https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=232663
> 
> So before your patches go in, we need to do a careful audit to make
> sure they don't interact properly with this patch which is already in
> e2fsprogs mainline.

This fix is already in our tree. We periodically keep syncing our tree
with the mainline changes. So I have tested my changes with this patch
present. 

Actually I had created test images for the expand-extra-isize patches
which failed on big-endian machines which brought these bugs to my
notice.

Thanks,
Kalpak.


-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html