lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Thu, 21 Jun 2007 11:37:57 -0600
From:	Andreas Dilger <>
To:	Girish Shilamkar <>
Cc:	Avantika Mathur <>,
Subject: Re: [PATCH] uninitialized groups ported - kernel

On Jun 20, 2007  17:26 +0530, Girish Shilamkar wrote:
>  			crc = crc16(crc, (__u8 *)gdp + offset,
> -				    sbi->s_es->s_desc_size - offset);
> +				    le16_to_cpu(sbi->s_es->s_desc_size)
> +					- offset);

Minor nit - please put '-' at the end of the previous line, and align
"offset" with '(sbi-> ...'.

Also, we're missing the signoff:

Signed-off-by: Andreas Dilger <>
Signed-off-by: Girish Shilamkar <>

Cheers, Andreas
Andreas Dilger
Principal Software Engineer
Cluster File Systems, Inc.

To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to
More majordomo info at

Powered by blists - more mailing lists