lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Fri, 22 Jun 2007 11:05:06 -0500
From:	Dave Kleikamp <shaggy@...ux.vnet.ibm.com>
To:	Girish Shilamkar <girish@...sterfs.com>
Cc:	Ext4 Mailing List <linux-ext4@...r.kernel.org>,
	Andreas Dilger <adilger@...sterfs.com>,
	Theodore Tso <tytso@....edu>, Mingming Cao <cmm@...ibm.com>
Subject: Re: [PATCH] Journal Checksum - rebased to 2.6.22-rc5

On Fri, 2007-06-22 at 15:06 +0530, Girish Shilamkar wrote:
> --- linux-2.6.22-rc5.orig/fs/jbd2/journal.c
> +++ linux-2.6.22-rc5/fs/jbd2/journal.c
> @@ -1272,6 +1272,33 @@ int jbd2_journal_set_features (journal_t
>         return 1;
>  }
> 
> +/**
> + * int jbd2_journal_clear_features () - Clear a given journal feature
> in the superblock
> + * @journal: Journal to act on.
> + * @compat: bitmask of compatible features
> + * @ro: bitmask of features that force read-only mount
> + * @incompat: bitmask of incompatible features
> + *
> + * Clear a given journal feature as present on the
> + * superblock.  Returns true if the requested features could be
> reset.
> + *
> + */
> +int jbd2_journal_clear_features (journal_t *journal, unsigned long
> compat,
> +                         unsigned long ro, unsigned long incompat)
> +{
> +       journal_superblock_t *sb;
> +
> +       jbd_debug(1, "Clear features 0x%lx/0x%lx/0x%lx\n",
> +                 compat, ro, incompat);
> +
> +       sb = journal->j_superblock;
> +
> +       sb->s_feature_compat    &= ~cpu_to_be32(compat);
> +       sb->s_feature_ro_compat &= ~cpu_to_be32(ro);
> +       sb->s_feature_incompat  &= ~cpu_to_be32(incompat);
> +
> +       return 1;
> +} 

This needs an EXPORT_SYMBOL(jbd2_journal_clear_features).  Otherwise,
ext4 can't be built as a module.
-- 
David Kleikamp
IBM Linux Technology Center

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists