lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Tue, 26 Jun 2007 13:24:10 +0900
From:	Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
To:	sct@...hat.com, akpm@...ux-foundation.org, adilger@...sterfs.com
Cc:	linux-ext4@...r.kernel.org
Subject: [Patch] mistaken ext4_inode_bitmap for ext4_block_bitmap

Hi.

I found an obvious mistake in ext4_new_blocks().
I made a fix patch for it.
Please confirm it.

This patch is for 2.6.22-rc5.

---

In ext4_new_blocks(), one of two ext4_block_bitmap() calls should be ext4_inode_bitmap() call.
It is not harmful in normal processing, but it should be fixed.

Signed-off-by: Toshiyuki Okajima <toshi.okajima@...fujitsu.com>
---
 fs/ext4/balloc.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.22-rc5.org/fs/ext4/balloc.c	2007-06-17 11:09:12.000000000 +0900
+++ linux-2.6.22-rc5/fs/ext4/balloc.c	2007-06-22 13:50:22.000000000 +0900
@@ -1585,7 +1585,7 @@ allocated:
 	ret_block = grp_alloc_blk + ext4_group_first_block_no(sb, group_no);

 	if (in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
-	    in_range(ext4_block_bitmap(sb, gdp), ret_block, num) ||
+	    in_range(ext4_inode_bitmap(sb, gdp), ret_block, num) ||
 	    in_range(ret_block, ext4_inode_table(sb, gdp),
 		     EXT4_SB(sb)->s_itb_per_group) ||
 	    in_range(ret_block + num - 1, ext4_inode_table(sb, gdp),

-
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists